Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8781 )
Change subject: IMPALA-6222: Add details to error msg on failure to get min reservation ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/8781/3/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/8781/3/be/src/runtime/mem-tracker.cc@324 PS3, Line 324: std::priority_queue<pair<int64_t, string>, vector<pair<int64_t, string>>, nit: add a using up the top of the file or in common/names.h instead of using the std:: prefixes. http://gerrit.cloudera.org:8080/#/c/8781/3/be/src/runtime/mem-tracker.cc@340 PS3, Line 340: int limit) { nit: weird wrapping. -- To view, visit http://gerrit.cloudera.org:8080/8781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4675fe923b33fdc4ddefd1872e6d6b803993d74 Gerrit-Change-Number: 8781 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2017 22:51:05 +0000 Gerrit-HasComments: Yes
