Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8802 )
Change subject: IMPALA-6291: disable AVX512 codegen in LLVM ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@110 PS2, Line 110: DEFINE_string(llvm_cpu_attr_whitelist, "sse2,cx16,prfchw,bmi2,fsgsbase,popcnt,aes,smap," > How do we ensure that codegen functions don't accidentally emit instruction Isn't that just something we need to catch in code review and testing? If we're branching on CpuInfo::IsSupported() we should be testing both branches in some fashion. http://gerrit.cloudera.org:8080/#/c/8802/2/be/src/codegen/llvm-codegen.cc@155 PS2, Line 155: target_features_attr_ > My understanding is that even if we blacklisted some instructions not on th Right. We also already handle the case where CPU attrs on the cross-compiled function are a subset of the system CPU attrs. -- To view, visit http://gerrit.cloudera.org:8080/8802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7c3ee3e370bafc50d855113485b7e6925f7bf6a Gerrit-Change-Number: 8802 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 08 Dec 2017 20:07:17 +0000 Gerrit-HasComments: Yes
