Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 )
Change subject: IMPALA-5237: Support a quoted string in date/time format ...................................................................... Patch Set 6: Code-Review-1 (2 comments) Currently I count not add the test case as you mentioned at the following change due to the issue at IMPALA-3942: https://gerrit.cloudera.org/#/c/8508/6/be/src/exprs/expr-test.cc We have two options. Which is better for you? Or any other option? Thanks. 1. Deliver a complete fix. Resolve IMPALA-3942 and then deliver this fix with a test case for mixing single and double quotes. 2. Deliver a first part of the fix which does not include the test case. Resolve IMPALA-3942 and then deliver a second part of the fix which includes the test case. I prefer the second one because we can deliver fixes incrementally. There will be some time for discussion and providing a solution to resolve blocker. http://gerrit.cloudera.org:8080/#/c/8508/6/be/src/runtime/timestamp-parse-util.h File be/src/runtime/timestamp-parse-util.h: http://gerrit.cloudera.org:8080/#/c/8508/6/be/src/runtime/timestamp-parse-util.h@190 PS6, Line 190: // nullptr if input does not have unclosed quote > My suggestion would be: Let me reflect it on the next patch set. http://gerrit.cloudera.org:8080/#/c/8508/6/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/8508/6/be/src/runtime/timestamp-parse-util.cc@178 PS6, Line 178: return quoted_string_begin + 1; > Yes I do. Okay, I accept your approach. -- To view, visit http://gerrit.cloudera.org:8080/8508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie34055ac695748bcfb110bfa6ed5308f469ea178 Gerrit-Change-Number: 8508 Gerrit-PatchSet: 6 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Dec 2017 03:31:29 +0000 Gerrit-HasComments: Yes
