Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 )
Change subject: IMPALA-3942: Fix unexpected conversion of string literal in front-end ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8818/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java File fe/src/main/java/org/apache/impala/analysis/StringLiteral.java: http://gerrit.cloudera.org:8080/#/c/8818/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@49 PS1, Line 49: boolean useSingleQuote = true; > Just considering what options we have here: Your suggestion is possible. Actually I tried what you suggested firstly which might be same as Jim's proposal, but I had to handle some corner cases because value_ contains can have non of/single/double quotes. I still have the ongoing code locally, but the change is bigger than this and I am not sure any hole still exists. If you and Jim still think "keeping a given string literal at value_", please let me know pros and cons compared with this version. -- To view, visit http://gerrit.cloudera.org:8080/8818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc4b5f5d8ffaa8feb96a466959427a04b3b06fec Gerrit-Change-Number: 8818 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 15 Dec 2017 00:10:23 +0000 Gerrit-HasComments: Yes
