Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 )
Change subject: IMPALA-3942: Fix wronly escaped string literal in front-end ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8818/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java File fe/src/main/java/org/apache/impala/analysis/StringLiteral.java: http://gerrit.cloudera.org:8080/#/c/8818/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@49 PS1, Line 49: boolean useSingleQuote = true; > Another, umh, "pragmatic" solution might be to just try both quotes and see This approach can be implemented easily, but I would prefer the above than this: 1. To avoid unnecessary overhead from try and error method. 2. More elaborative and robust code. 3. Fix for the problem is not urgent. http://gerrit.cloudera.org:8080/#/c/8818/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@49 PS1, Line 49: boolean useSingleQuote = true; > I think all proposed approaches do not consider that string literals can al Thanks a lot for the information. I didn't aware of the string literal can come from the rewritter rule. The normalization stage should be required, so I introduced getEscapedValue() method in the recent patch set. -- To view, visit http://gerrit.cloudera.org:8080/8818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc4b5f5d8ffaa8feb96a466959427a04b3b06fec Gerrit-Change-Number: 8818 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 18 Dec 2017 08:32:04 +0000 Gerrit-HasComments: Yes
