Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 )
Change subject: IMPALA-3193: Show table's comment on show tables ...................................................................... Patch Set 3: Thanks for working on this jira. I have a high level comment about the current patch. The way you've implemented it, you're serializing all the metadata for all the tables in a database which is way too expensive and can cause a number of problems. You should try sending the minimal information needed which is the table name and comment and also make sure you do it only for loaded tables, i.e. don't trigger a full metadata load if a table is not loaded just to get the comment string. -- To view, visit http://gerrit.cloudera.org:8080/8851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd Gerrit-Change-Number: 8851 Gerrit-PatchSet: 3 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2017 18:50:17 +0000 Gerrit-HasComments: No
