Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 )
Change subject: IMPALA-3193: Show table's comment on show tables ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8851/5/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/8851/5/common/thrift/Frontend.thrift@70 PS5, Line 70: Arguments to getTableNamesAndComments I think we can clean up the API a bit. Instead of having getTableNames and getTableNamesAndComments, how about we create a single getTablesInfo call that takes a TGetTablesInfoParams (renamed TGetTablesParams) argument and returns a TGetTablesInfoResult (renamed TGetTablesResult). The latter returns a list<TTableInfo>, where TTableInfo has a required name and optional comment field. That way, we avoid the checks around the length of list of names and list of comments and it's easier to expand it if in the future we decide to add additional information such as table creation time, owner, etc. -- To view, visit http://gerrit.cloudera.org:8080/8851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd Gerrit-Change-Number: 8851 Gerrit-PatchSet: 5 Gerrit-Owner: Kim Jin Chul <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Kim Jin Chul <[email protected]> Gerrit-Comment-Date: Thu, 11 Jan 2018 21:38:38 +0000 Gerrit-HasComments: Yes
