Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8852 )

Change subject: IMPALA-6318: Adjustment for hanging query cancellation test
......................................................................


Patch Set 4:

Indeed, nice catch! Thanks, Tim! And sorry for being that superficial with the 
investigation.
Interestingly no stdout is displayed when I run the tests, I guess the testing 
framework swallows them, but still directing it to devnull would be much better.

After being done some research I think this is the solution we need:
FNULL = open(os.devnull, 'w')
Popen(..., stdout=FNULL...)


--
To view, visit http://gerrit.cloudera.org:8080/8852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I082c83b91b6d0c527de92c7992f0dc9d1b290433
Gerrit-Change-Number: 8852
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Sun, 17 Dec 2017 07:50:41 +0000
Gerrit-HasComments: No

Reply via email to