Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8852 )
Change subject: IMPALA-6318: Adjustment for hanging query cancellation test ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/8852/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8852/5//COMMIT_MSG@15 PS5, Line 15: theory what might be going on here: The query is cancelled > nit: maybe you could mention that there is a known issue with subprocess.co Done http://gerrit.cloudera.org:8080/#/c/8852/5/tests/shell/util.py File tests/shell/util.py: http://gerrit.cloudera.org:8080/#/c/8852/5/tests/shell/util.py@162 PS5, Line 162: return result > It's weird that this both takes self and arguments. I would have expected _ Done -- To view, visit http://gerrit.cloudera.org:8080/8852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I082c83b91b6d0c527de92c7992f0dc9d1b290433 Gerrit-Change-Number: 8852 Gerrit-PatchSet: 6 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 27 Dec 2017 13:55:56 +0000 Gerrit-HasComments: Yes
