Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 )
Change subject: KUDU-2228: Make Messenger options configurable ...................................................................... Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/client_negotiation.h File be/src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/client_negotiation.h@65 PS1, Line 65: security:: Added security:: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/client_negotiation.h@224 PS1, Line 224: security:: Added security:: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/messenger.cc File be/src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/messenger.cc@a30 PS1, Line 30: : Some conflicts here. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/messenger.cc@a50 PS1, Line 50: : : Some conflicts here. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/sasl_common.cc File be/src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/sasl_common.cc@a28 PS1, Line 28: Conflict here. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/server_negotiation.h File be/src/kudu/rpc/server_negotiation.h: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/server_negotiation.h@62 PS1, Line 62: security:: Added security:: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/rpc/server_negotiation.h@224 PS1, Line 224: security:: Added security:: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/security/init.cc File be/src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/security/init.cc@a33 PS1, Line 33: : : : : : : Some conflicts in the header files here. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/security/init.cc@a45 PS1, Line 45: Some conflicts here due to missing fix of KUDU-1955, which was mostly undone by this change anyway. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/security/test/mini_kdc-test.cc File be/src/kudu/security/test/mini_kdc-test.cc: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/security/test/mini_kdc-test.cc@a21 PS1, Line 21: Conflicts here due to difference in header file names. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/security/test/mini_kdc-test.cc@20 PS1, Line 20: #include <boost/optional/optional.hpp> Conflicts here. Changed from <boost/optional.hpp> to <boost/optional/optional.hpp>. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/util/flags.h File be/src/kudu/util/flags.h: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/kudu/util/flags.h@a24 PS1, Line 24: Conflicts here. http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/8878/1/be/src/rpc/authentication.cc@847 PS1, Line 847: InitKerberosForServer(principal_, keytab_file_ Change in interface here. -- To view, visit http://gerrit.cloudera.org:8080/8878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba Gerrit-Change-Number: 8878 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Comment-Date: Tue, 19 Dec 2017 03:39:39 +0000 Gerrit-HasComments: Yes
