Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8878 )
Change subject: KUDU-2228: Make Messenger options configurable ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8878/2/be/src/kudu/util/flags.h File be/src/kudu/util/flags.h: http://gerrit.cloudera.org:8080/#/c/8878/2/be/src/kudu/util/flags.h@24 PS2, Line 24: #include "kudu/gutil/macros.h" > Is this necessary? I was able to build without it. Removed. Didn't mean to include unnecessary changes which are not part of the original patch. Anyhow, this can be removed. http://gerrit.cloudera.org:8080/#/c/8878/2/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/8878/2/be/src/rpc/authentication.cc@847 PS2, Line 847: keytab_file_ > We should mention this in the commit message. It's not just a cherry-pick b Done -- To view, visit http://gerrit.cloudera.org:8080/8878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia21814ffb6e283c2791985b089878b579905f0ba Gerrit-Change-Number: 8878 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Tue, 02 Jan 2018 22:11:21 +0000 Gerrit-HasComments: Yes
