Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8541 )
Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module ...................................................................... IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module Currently, if an error is encountered during the creation of a handcrafted codegen method, then the resulting IR is left in an incomplete state. This patch ensures that all such IRs are cleaned up (method is deleted from the module) before the llvm module is finalized. Testing: - added a backend test to exercise the added code path. - tested manually by executing the following query: select * from charTable A, charTable B where A.charColumn = B.charColumn and A.charColumn = 'foo'; and looking at the logs to verify that 'InsertRuntimeFilters' and 'FilterContextInsert' methods have been removed. Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f Reviewed-on: http://gerrit.cloudera.org:8080/8541 Reviewed-by: Bikramjeet Vig <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/codegen/llvm-codegen-test.cc M be/src/codegen/llvm-codegen.cc M be/src/codegen/llvm-codegen.h M be/src/exec/hdfs-text-scanner.cc M be/src/exprs/scalar-fn-call.cc 5 files changed, 104 insertions(+), 35 deletions(-) Approvals: Bikramjeet Vig: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f Gerrit-Change-Number: 8541 Gerrit-PatchSet: 16 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
