Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8541 )
Change subject: IMPALA-6177: Cleanup incomplete handcrafted IRs before finalizing module ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/8541/13/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/8541/13/be/src/codegen/llvm-codegen.cc@898 PS13, Line 898: ReplaceCallSites should i add a dcheck for here to check if the replacement function is finalized? This would prevent us from running into a situation where impala would crash if the replacement function is not finalized and gets removed before finalizing the module. -- To view, visit http://gerrit.cloudera.org:8080/8541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If975cfb3906482b36dd6ede32ca81de6fcee1d7f Gerrit-Change-Number: 8541 Gerrit-PatchSet: 13 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Dec 2017 19:32:08 +0000 Gerrit-HasComments: Yes
