Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8923 )
Change subject: In order to fix IMPALA-6296, have added a condition check to ensure 'emit_perf_map_' evaluates to true before the dependent object(perf_map_lock_) is asserted using DCHECK. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8923/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8923/2//COMMIT_MSG@7 PS2, Line 7: In order to fix IMPALA-6296, have added a condition check to ensure 'emit_perf_map_' evaluates to true before the dependent object(perf_map_lock_) is asserted using DCHECK. The first line of your commit message should have the JIRA number followed by a short title describing what the patch does. Then put a brief description of the patch below. You should also wrap lines here. See the wiki page about contributing: https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala or look at other reviews for examples: https://gerrit.cloudera.org/#/q/project:Impala-ASF -- To view, visit http://gerrit.cloudera.org:8080/8923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e Gerrit-Change-Number: 8923 Gerrit-PatchSet: 2 Gerrit-Owner: Manaswini Maharana <manaswini.mahar...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Jan 2018 19:53:25 +0000 Gerrit-HasComments: Yes
