Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8923 )
Change subject: IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode ...................................................................... IMPALA-6296: Avoid crash caused by DCHECK in Codegen in debug mode Currently, when debug mode is enabled, any query using codegen can result in an Impala daemon crash as it hits a DCHECK. This patch ensures the DCHECK is hit only when specific condition is met to avoid the crash. That condition here is to DCHECK only when 'emit_perf_map_' evaluates to True ensuring 'perf_map_lock_' is not empty when asserted. Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e Reviewed-on: http://gerrit.cloudera.org:8080/8923 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Reviewed-by: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/codegen/codegen-symbol-emitter.cc 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Tim Armstrong: Looks good to me, but someone else must approve Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I93e2b1efb325100d01d398e68e789d87b877167e Gerrit-Change-Number: 8923 Gerrit-PatchSet: 6 Gerrit-Owner: Manaswini Maharana <manaswini.mahar...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Manaswini Maharana <manaswini.mahar...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
