Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8934 )
Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8934/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8934/2//COMMIT_MSG@29 PS2, Line 29: Other fields in the runtime profile are left unredacted. This implicitly states that we aren't allowed to log anything sensitive in any field other than the above 4 mentioned. Is that commented or documented somewhere? If not, it would be good to add that. http://gerrit.cloudera.org:8080/#/c/8934/2/tests/custom_cluster/test_redaction.py File tests/custom_cluster/test_redaction.py: http://gerrit.cloudera.org:8080/#/c/8934/2/tests/custom_cluster/test_redaction.py@336 PS2, Line 336: self.assert_query_profile_contains(self.find_last_query_id(), user_profile_pattern) Should we do this again? It's already done on L313? http://gerrit.cloudera.org:8080/#/c/8934/2/tests/custom_cluster/test_redaction.py@337 PS2, Line 337: assert_query_profile_contains Why not use assert_web_ui_redaction() here? -- To view, visit http://gerrit.cloudera.org:8080/8934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae3b6726009bf458a7ec73131e5d659b12ab73cf Gerrit-Change-Number: 8934 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 04 Jan 2018 21:47:21 +0000 Gerrit-HasComments: Yes
