Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/8934 )
Change subject: IMPALA-6348: Redact only sensitive fields in runtime profiles ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/8934/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8934/2//COMMIT_MSG@29 PS2, Line 29: Other fields in the runtime profile are left unredacted. > This implicitly states that we aren't allowed to log anything sensitive in Done http://gerrit.cloudera.org:8080/#/c/8934/2/tests/custom_cluster/test_redaction.py File tests/custom_cluster/test_redaction.py: http://gerrit.cloudera.org:8080/#/c/8934/2/tests/custom_cluster/test_redaction.py@302 PS2, Line 302: "replace":"redacted user" > nit: space missing Done http://gerrit.cloudera.org:8080/#/c/8934/2/tests/custom_cluster/test_redaction.py@336 PS2, Line 336: self.assert_query_profile_contains(self.find_last_query_id(), user_profile_pattern) > Should we do this again? It's already done on L313? You mean L315/L317? We ran a different query in L335, find_last_query_id() now points to that, so essentially we are grep'ing a different page? http://gerrit.cloudera.org:8080/#/c/8934/2/tests/custom_cluster/test_redaction.py@337 PS2, Line 337: assert_query_profile_contains > Why not use assert_web_ui_redaction() here? This change redacts only the "username" from the query stmt but not from the "User: <user>" part. For ex: if user is jenkins, we can have the following in the runtime-profile. User: jenkins Query stmt: SELECT string_col = 'redacted user', COUNT(*) FROM functional.alltypes GROUP BY 1 assert_web_ui_redaction() fails since it expects the string_to_redacted is not present anywhere. -- To view, visit http://gerrit.cloudera.org:8080/8934 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae3b6726009bf458a7ec73131e5d659b12ab73cf Gerrit-Change-Number: 8934 Gerrit-PatchSet: 2 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 05 Jan 2018 23:45:10 +0000 Gerrit-HasComments: Yes
