anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 )
Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/8548/1/testdata/data/signed_integer_logical_types.parquet File testdata/data/signed_integer_logical_types.parquet: PS1: > Can you add a description of this file to the readme - i.e. what it has in Done http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@295 PS1, Line 295: column > column Done http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@303 PS1, Line 303: stored as parquet""".format(src_tbl, hdfs_path) > Why is there a space after {1}? Removed http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@321 PS1, Line 321: result = self.execute_query_expect_success(self.client, insert_stmt) > remove semicolon Done http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@325 PS1, Line 325: ame values in > should these (above and below as well) be execute_query_expect_success? Done http://gerrit.cloudera.org:8080/#/c/8548/1/tests/query_test/test_insert_parquet.py@331 PS1, Line 331: dst_tbl = "{0}.{1}".format(unique_database, "read_write_logical_type_dst") > +1. I think the test would be a little easier to understand too if we asser Done -- To view, visit http://gerrit.cloudera.org:8080/8548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47a8371858c9597c6a440808cf6f933532468927 Gerrit-Change-Number: 8548 Gerrit-PatchSet: 2 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 05 Jan 2018 02:45:33 +0000 Gerrit-HasComments: Yes
