anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 )
Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/8548/2/tests/query_test/test_insert_parquet.py File tests/query_test/test_insert_parquet.py: http://gerrit.cloudera.org:8080/#/c/8548/2/tests/query_test/test_insert_parquet.py@310 PS2, Line 310: if line_split[0] == "id": > Can you make this an elif chain and assert that the column name is one of t Done http://gerrit.cloudera.org:8080/#/c/8548/2/tests/query_test/test_insert_parquet.py@339 PS2, Line 339: if line_split[0] == "id": > Same here Done http://gerrit.cloudera.org:8080/#/c/8548/2/tests/query_test/test_insert_parquet.py@349 PS2, Line 349: > nit: missing space after % Done http://gerrit.cloudera.org:8080/#/c/8548/2/tests/query_test/test_insert_parquet.py@351 PS2, Line 351: c > same here Done -- To view, visit http://gerrit.cloudera.org:8080/8548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47a8371858c9597c6a440808cf6f933532468927 Gerrit-Change-Number: 8548 Gerrit-PatchSet: 3 Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Mon, 08 Jan 2018 22:57:48 +0000 Gerrit-HasComments: Yes
