Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8888 )
Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8888/1/be/src/util/mem-info.cc File be/src/util/mem-info.cc: http://gerrit.cloudera.org:8080/#/c/8888/1/be/src/util/mem-info.cc@131 PS1, Line 131: line.find_first_not_of(" ", colon_pos + 1) > Can this return string::npos ? Will that be a reasonable input to line.subs It can. I wrote a quick test program and it crashed. Good catch. -- To view, visit http://gerrit.cloudera.org:8080/8888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd807f869a9359d991ba515177fb2298054520e Gerrit-Change-Number: 8888 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Tue, 09 Jan 2018 23:52:35 +0000 Gerrit-HasComments: Yes
