Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8888 )
Change subject: IMPALA-6330, IMPALA-5702: Avoid boost's trim() to workaround crash after dynamic linking. ...................................................................... Patch Set 2: (1 comment) The change LGTM. Please confirm the answer for the question below and I can +2 it. http://gerrit.cloudera.org:8080/#/c/8888/2/be/src/util/mem-info.cc File be/src/util/mem-info.cc: http://gerrit.cloudera.org:8080/#/c/8888/2/be/src/util/mem-info.cc@130 PS2, Line 130: " " Sorry to keep picking on this but does boost::trim() also consider "tab" as space or is it purely space character ? It's probably worth double checking just in case. -- To view, visit http://gerrit.cloudera.org:8080/8888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd807f869a9359d991ba515177fb2298054520e Gerrit-Change-Number: 8888 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 10 Jan 2018 01:01:18 +0000 Gerrit-HasComments: Yes
