Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 )
Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries ...................................................................... Patch Set 3: (3 comments) couple of small clarifying comments. http://gerrit.cloudera.org:8080/#/c/9005/3/be/src/exec/scalar-check-node.h File be/src/exec/scalar-check-node.h: http://gerrit.cloudera.org:8080/#/c/9005/3/be/src/exec/scalar-check-node.h@29 PS3, Line 29: ScalarCheckNode small naming nit, but it seems that this class checks that the cardinality of the child is <= 1. It does not guarantee that the child produces a scalar (could be a multi-column row). perhaps CardinalityCheckNode? true that the frontend should guarantee arity here, but perhaps it should be checked/asserted or the name should match the more general functionality. http://gerrit.cloudera.org:8080/#/c/9005/3/be/src/exec/scalar-check-node.cc File be/src/exec/scalar-check-node.cc: http://gerrit.cloudera.org:8080/#/c/9005/3/be/src/exec/scalar-check-node.cc@57 PS3, Line 57: scalar what guarantees a scalar here? http://gerrit.cloudera.org:8080/#/c/9005/3/fe/src/main/java/org/apache/impala/planner/ScalarCheckNode.java File fe/src/main/java/org/apache/impala/planner/ScalarCheckNode.java: http://gerrit.cloudera.org:8080/#/c/9005/3/fe/src/main/java/org/apache/impala/planner/ScalarCheckNode.java@26 PS3, Line 26: conjuncts and a limit clause. what conjuncts and what limit? perhaps phrase this to be more specific. -- To view, visit http://gerrit.cloudera.org:8080/9005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f52b93a60eeacedd242a2f17fa6b99c4fc38e06 Gerrit-Change-Number: 9005 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 Jan 2018 18:49:51 +0000 Gerrit-HasComments: Yes
