Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 )
Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/9005/4/be/src/exec/cardinality-check-node.h File be/src/exec/cardinality-check-node.h: http://gerrit.cloudera.org:8080/#/c/9005/4/be/src/exec/cardinality-check-node.h@27 PS4, Line 27: Node that passes along the row pulled from its child unchanged. : /// If there is more than one row, it aborts the query. sync this with the changes: - <= max_cardinality_ is now permitted (not necessarily 1) - more than one row may be returned, so generalize to ".. passes along rows ..." http://gerrit.cloudera.org:8080/#/c/9005/4/be/src/exec/cardinality-check-node.cc File be/src/exec/cardinality-check-node.cc: http://gerrit.cloudera.org:8080/#/c/9005/4/be/src/exec/cardinality-check-node.cc@61 PS4, Line 61: > 1 shouldn't this be max_cardinality_? http://gerrit.cloudera.org:8080/#/c/9005/4/be/src/exec/cardinality-check-node.cc@65 PS4, Line 65: h.num_rows() == 1 this is another check that seems to have been carried from the stricter <= 1 implementation. if there are no tests for > 1 limit, then perhaps this should be paired back down to <= 1 ? Speaking of which, if its not possible to create a plan for the node from the FE, is the general approach to pair back the functionality? otherwise, I'd expect tests independent of the FE. http://gerrit.cloudera.org:8080/#/c/9005/4/be/src/exec/cardinality-check-node.cc@69 PS4, Line 69: ted, 1); same here http://gerrit.cloudera.org:8080/#/c/9005/4/be/src/exec/cardinality-check-node.cc@85 PS4, Line 85: == 1 and here -- To view, visit http://gerrit.cloudera.org:8080/9005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f52b93a60eeacedd242a2f17fa6b99c4fc38e06 Gerrit-Change-Number: 9005 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2018 00:37:01 +0000 Gerrit-HasComments: Yes
