Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 )
Change subject: IMPALA-4993: extend dictionary filtering to collections ...................................................................... Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/8775/15/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8775/15/be/src/exec/hdfs-parquet-scanner.cc@1645 PS15, Line 1645: Status HdfsParquetScanner::InitColumns( > Nice catch! Looks like a bug to me too. The code seems to assume that all c Yeah. I wonder if it would work out simpler if we had: dict_filterable_columns_ -> flattened list of all scalar column readers with dict filters non_dict_filterable_columns_ -> flattened list of all scalar column readers with dict filters collection_columns_ -> flattened list of all collection column readers Then InitScalarColumns() and InitCollectionColumns() could be separate operations that iterate over flat vectors and don't need to recurse. -- To view, visit http://gerrit.cloudera.org:8080/8775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3a2abcfc3d0f7d18756816659fed77ce12668dd Gerrit-Change-Number: 8775 Gerrit-PatchSet: 15 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Sat, 13 Jan 2018 00:42:03 +0000 Gerrit-HasComments: Yes
