Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 )
Change subject: IMPALA-4993: extend dictionary filtering to collections ...................................................................... Patch Set 18: Code-Review+1 (1 comment) Thanks for fixing this gap in test coverage! Will also give Alex a change to look. http://gerrit.cloudera.org:8080/#/c/8775/18/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/8775/18/testdata/bin/create-load-data.sh@443 PS18, Line 443: # IMPALA-4993: Add tests where nested collections are stored in more than row-group We unfortunately have multiple ways to load custom data files for tests. Doing it in this shell script isn't ideal and we may want to switch to some other method at some point. However, this seems like the best approach for now so it's consistent with the other multi-block/row group files -- To view, visit http://gerrit.cloudera.org:8080/8775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3a2abcfc3d0f7d18756816659fed77ce12668dd Gerrit-Change-Number: 8775 Gerrit-PatchSet: 18 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 23:01:23 +0000 Gerrit-HasComments: Yes
