Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9023 )
Change subject: IMPALA-6382: Cap default and min spillable buffer size query options ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9023/1/be/src/exec/exec-node.h File be/src/exec/exec-node.h: http://gerrit.cloudera.org:8080/#/c/9023/1/be/src/exec/exec-node.h@227 PS1, Line 227: static const int64_t MAX_SPILLABLE_BUFFER_SIZE = 1LL << 40; // 1 TB > This feels like a slightly weird place to put this, and its unfortunate for I think we should just have the constant in query-options.cc instead of adding this cross-module dependency. http://gerrit.cloudera.org:8080/#/c/9023/1/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/9023/1/be/src/service/query-options.cc@573 PS1, Line 573: case TImpalaQueryOptions::MAX_ROW_SIZE: { I wonder if there's a similar bug with MAX_ROW_SIZE -- To view, visit http://gerrit.cloudera.org:8080/9023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36d3915f7019b13c3eb06f08bfdb38c71ec864f1 Gerrit-Change-Number: 9023 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 16 Jan 2018 23:44:14 +0000 Gerrit-HasComments: Yes
