Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9023 )
Change subject: IMPALA-6382: Cap spillable buffer size and max row size query options ...................................................................... IMPALA-6382: Cap spillable buffer size and max row size query options Currently the default and min spillable buffer size and max row size query options accept any valid int64 value. Since the planner depends on these values for memory estimations, if a very large value close to the limits of int64 is set, the variables representing or relying on these estimates can overflow during different phases of query execution. This patch puts a reasonable upper limit of 1TB to these query options to prevent such a situation. Testing: Added backend query option tests. Change-Id: I36d3915f7019b13c3eb06f08bfdb38c71ec864f1 Reviewed-on: http://gerrit.cloudera.org:8080/9023 Reviewed-by: Bikramjeet Vig <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/service/query-options-test.cc M be/src/service/query-options.cc M be/src/service/query-options.h M testdata/workloads/functional-query/queries/QueryTest/set.test 4 files changed, 34 insertions(+), 8 deletions(-) Approvals: Bikramjeet Vig: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I36d3915f7019b13c3eb06f08bfdb38c71ec864f1 Gerrit-Change-Number: 9023 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
