Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9045 )
Change subject: IMPALA-6410: Tool to cherrypick changes across branches. ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9045/2/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/9045/2/bin/compare_branches.py@21 PS2, Line 21: # [ { "source": "master", "target": "2.x", "commits": [ "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb" ] } ] > long line Done http://gerrit.cloudera.org:8080/#/c/9045/2/bin/compare_branches.py@30 PS2, Line 30: from pprint import pformat > We should have "import..." grouped together and sorted, followed by "from . Done http://gerrit.cloudera.org:8080/#/c/9045/2/bin/compare_branches.py@179 PS2, Line 179: print "Cherrypicking %d changes." % (len(cherry_pick_hashes),) > The main() function seems long. Do you think it would make sense to separat I moved out cherrypick and the argument parser. I didn't refactor 142-167, which could be done, but I'm not sure is worth it. -- To view, visit http://gerrit.cloudera.org:8080/9045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6120ec2d6e914a1e5fda568178b32aafda8722a9 Gerrit-Change-Number: 9045 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2018 23:14:17 +0000 Gerrit-HasComments: Yes
