Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9045 )
Change subject: IMPALA-6410: Tool to cherrypick changes across branches. ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/9045/3/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/9045/3/bin/compare_branches.py@79 PS3, Line 79: e > I see that below, but this is about the change-id, not the JIRA, yes? Ah, I misread what you meant. I logged a warning. (re.search() only ever finds the first one, so I switched to re.findall()). http://gerrit.cloudera.org:8080/#/c/9045/4/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/9045/4/bin/compare_branches.py@150 PS4, Line 150: __import__("pdb").set_trace() > Have you seen this happen? How did you trigger it? Sorry; left in some debugging here. Lines 141 and 144 were the cases where this happens. Removed the try/except. http://gerrit.cloudera.org:8080/#/c/9045/4/bin/compare_branches.py@163 PS4, Line 163: Cherrypicks the given commits after ascertaining that full_target_branch_name > nit: can you follow pep-257 for this function, as well? Done -- To view, visit http://gerrit.cloudera.org:8080/9045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6120ec2d6e914a1e5fda568178b32aafda8722a9 Gerrit-Change-Number: 9045 Gerrit-PatchSet: 4 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Jan 2018 19:25:52 +0000 Gerrit-HasComments: Yes
