Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 )
Change subject: IMPALA-4993: extend dictionary filtering to collections ...................................................................... Patch Set 18: (2 comments) after a couple glitches with loading test data, these tests pass now so we should be set. http://gerrit.cloudera.org:8080/#/c/8775/18/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/8775/18/be/src/exec/hdfs-parquet-scanner.cc@1616 PS18, Line 1616: void HdfsParquetScanner::InitCollectionColumns(int row_group_idx) { > remove row_group_idx param Done http://gerrit.cloudera.org:8080/#/c/8775/18/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/8775/18/testdata/bin/create-load-data.sh@443 PS18, Line 443: # IMPALA-4993: Add tests where nested collections are stored in more than row-group > We unfortunately have multiple ways to load custom data files for tests. Do I switched it to a dependent load section in the function spec file. -- To view, visit http://gerrit.cloudera.org:8080/8775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3a2abcfc3d0f7d18756816659fed77ce12668dd Gerrit-Change-Number: 8775 Gerrit-PatchSet: 18 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2018 02:20:30 +0000 Gerrit-HasComments: Yes
