Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 )
Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption ...................................................................... Patch Set 7: (1 comment) Thank you for the patch! It looks good, we just need to update the interface and comments to EncryptionKey because the usage pattern of the interface has changed subtle. http://gerrit.cloudera.org:8080/#/c/9032/7/be/src/util/openssl-util.h File be/src/util/openssl-util.h: http://gerrit.cloudera.org:8080/#/c/9032/7/be/src/util/openssl-util.h@116 PS7, Line 116: const This isn't really const if it modifies gcm_tag_, so we should remove the const specifier. This also changes the relationship between Encrypt() and Decrypt(), because they are now stateful and Decrypt() can only decrypt the result of the last Encrypt() call. This actually seems fine, but we should remove the "const" and update the comments for Encrypt() and Decrypt(). -- To view, visit http://gerrit.cloudera.org:8080/9032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ea87b82a8897ee8bfa187715ac1c52883790d24 Gerrit-Change-Number: 9032 Gerrit-PatchSet: 7 Gerrit-Owner: Xianda Ke <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Xianda Ke <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 22 Jan 2018 22:00:04 +0000 Gerrit-HasComments: Yes
