Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 )
Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption ...................................................................... Patch Set 10: (1 comment) > (1 comment) Yes. It could be false if we are running on a system without GCM support. > (1 comment) http://gerrit.cloudera.org:8080/#/c/9032/9/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/9032/9/be/src/util/openssl-util-test.cc@149 PS9, Line 149: // Check if GCM mode > Any update on this comment? Thank Sailesh for the comments. Even it has been set as GCM mode, it may fall back to other modes. So no DCHECK needed. I just add a line of comment in Patch Set 10. Thanks a lot -- To view, visit http://gerrit.cloudera.org:8080/9032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ea87b82a8897ee8bfa187715ac1c52883790d24 Gerrit-Change-Number: 9032 Gerrit-PatchSet: 10 Gerrit-Owner: Xianda Ke <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Xianda Ke <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2018 06:38:13 +0000 Gerrit-HasComments: Yes
