anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 )
Change subject: IMPALA-6435: Disable codegen for CHAR literals. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9102/1/be/src/exprs/literal.cc File be/src/exprs/literal.cc: http://gerrit.cloudera.org:8080/#/c/9102/1/be/src/exprs/literal.cc@a392 PS1, Line 392: > This seems wrong; you deleted the handlig for TYPE_STRING. Ooops! Sorry I had removed some of the code to debug some test failure. Forgot to git add it back again. Removed the TYPE_CHAR case here and I return earlier. -- To view, visit http://gerrit.cloudera.org:8080/9102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73 Gerrit-Change-Number: 9102 Gerrit-PatchSet: 3 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Tue, 23 Jan 2018 21:20:31 +0000 Gerrit-HasComments: Yes
