anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 )
Change subject: IMPALA-6435: Disable codegen for CHAR literals. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9102/3/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test File testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test: http://gerrit.cloudera.org:8080/#/c/9102/3/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test@38 PS3, Line 38: select cast('a' as char(4)) as s from functional.alltypestiny > Can you add a similar test for cast(NULL as char(4))? Or add it to this que Done -- To view, visit http://gerrit.cloudera.org:8080/9102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e4e27350c53bc69ce412a004e392e7480214f73 Gerrit-Change-Number: 9102 Gerrit-PatchSet: 4 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Wed, 24 Jan 2018 01:40:19 +0000 Gerrit-HasComments: Yes
