Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 )
Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/9121/2/be/src/kudu/rpc/rpcz_store.cc File be/src/kudu/rpc/rpcz_store.cc: http://gerrit.cloudera.org:8080/#/c/9121/2/be/src/kudu/rpc/rpcz_store.cc@44 PS2, Line 44: "Threshold (in milliseconds) above which a RPC is considered too long and its " nit: The lines look too long in Gerrit. http://gerrit.cloudera.org:8080/#/c/9121/2/be/src/kudu/rpc/rpcz_store.cc@45 PS2, Line 45: The time measured is between " : "when a RPC is accepted and when its call handler completes nit: The time is measured from when an RPC is accepted until its call handler completes. -- To view, visit http://gerrit.cloudera.org:8080/9121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie587ee602e83bb65d74f7ee622a9bc47897f2574 Gerrit-Change-Number: 9121 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 24 Jan 2018 23:25:30 +0000 Gerrit-HasComments: Yes
