Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9121 )
Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9121/2/be/src/kudu/rpc/rpcz_store.cc File be/src/kudu/rpc/rpcz_store.cc: http://gerrit.cloudera.org:8080/#/c/9121/2/be/src/kudu/rpc/rpcz_store.cc@44 PS2, Line 44: "Threshold (in milliseconds) above which a RPC is considered too long and its " > nit: The lines look too long in Gerrit. Apparently, the Kudu codebase doesn't seem to limit to 90 characters per line for some reasons. Keeping it the same to avoid future conflicts. http://gerrit.cloudera.org:8080/#/c/9121/2/be/src/kudu/rpc/rpcz_store.cc@45 PS2, Line 45: The time measured is between " : "when a RPC is accepted and when its call handler completes > nit: The time is measured from when an RPC is accepted until its call handl Keeping it the same to avoid future conflicts. I can push another change on Kudu side to fix up the wording if you think it's worth it. -- To view, visit http://gerrit.cloudera.org:8080/9121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie587ee602e83bb65d74f7ee622a9bc47897f2574 Gerrit-Change-Number: 9121 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 24 Jan 2018 23:44:15 +0000 Gerrit-HasComments: Yes
