Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 )
Change subject: IMPALA-6444: CTAS STORED AS KUDU to support reordering of columns ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9147/4/fe/src/main/java/org/apache/impala/catalog/KuduTable.java File fe/src/main/java/org/apache/impala/catalog/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/9147/4/fe/src/main/java/org/apache/impala/catalog/KuduTable.java@393 PS4, Line 393: if (!result) { > Sorry for the late addition. I think the first check is not needed anymore. yes but the first one is a fast path and this one is a slow path so I didn't remove the former check -- To view, visit http://gerrit.cloudera.org:8080/9147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2 Gerrit-Change-Number: 9147 Gerrit-PatchSet: 4 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Mon, 29 Jan 2018 23:46:05 +0000 Gerrit-HasComments: Yes
