Hello Lars Volker, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9147
to look at the new patch set (#8).
Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or
primary key column names.
......................................................................
IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key
column names.
CTAS into Kudu fails if the primary key and/or the partition column names are
not
specified in lower case.The problem is that we pass in the primary key column
names
directly from the parser instead we should be passing the post-analysis
ColumnDefs
as primary keys. So it is fixed by making changes to createCtasTarget()
in KuduTable class to take a list of ColumnDef class associated with the
primary keys
from getPrimaryKeyColumnDefs() in CreateTableStmt class.
ColumnDef class has column names stored in lower case that are used by
createCtasTarget()
to populate primaryKeyColumnNames_ in KuduTable class that resolves the issue.
Testing
-------
Verified against the newly added test case that reproduces the issue without
the fix.
Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2
---
M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/kudu_create.test
5 files changed, 16 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/9147/8
--
To view, visit http://gerrit.cloudera.org:8080/9147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica1c8ec1544339e9e80733a7a0c78594e0a727d2
Gerrit-Change-Number: 9147
Gerrit-PatchSet: 8
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Pranay Singh
