Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9153 )

Change subject: IMPALA-5293: Turn insert clustering on by default
......................................................................


Patch Set 5:

(1 comment)

Thanks for the review. The latest PS also fixes some tests that had failed in a 
private exhaustive run. I'm currently rerunning an exhaustive build with the 
latest PS.

http://gerrit.cloudera.org:8080/#/c/9153/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:

http://gerrit.cloudera.org:8080/#/c/9153/3/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@831
PS3, Line 831:         hasClusteredHint_ = true;
> I'd lean towards re-adding it for Kudu tables, although it is not that usef
Sounds good to me. I created IMPALA-6466 to add documentation for the clustered 
hint for Kudu tables.



--
To view, visit http://gerrit.cloudera.org:8080/9153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbf2368cf4415e6ecfa65058daf6ff87ef62f9d9
Gerrit-Change-Number: 9153
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 31 Jan 2018 19:33:27 +0000
Gerrit-HasComments: Yes

Reply via email to