Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 )
Change subject: IMPALA-5293: Turn insert clustering on by default ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/9153/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9153/5//COMMIT_MSG@11 PS5, Line 11: to a query plan. Specifying 'clustered' will now issue a warning. The Why does clustered issue a warning? We change defaults all the time and users might want to fix the plan with hints. I don't think we should warn if hints have no effect. http://gerrit.cloudera.org:8080/#/c/9153/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/9153/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1893 PS5, Line 1893: // Test that clustered hint issues a warning. Where's the expected warning? http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/insert.test File testdata/workloads/functional-planner/queries/PlannerTest/insert.test: http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/insert.test@813 PS5, Line 813: # IMPALA-6280: clustered (default) with outer join, inline view, and TupleisNullPredicate Where did this come from? Would be great to avoid using alltypesinsert outside of the end-to-end tests. That table is pretty weird and probably should not be part of our functional_schema_template, but that's a longer story http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/with-clause.test File testdata/workloads/functional-planner/queries/PlannerTest/with-clause.test: http://gerrit.cloudera.org:8080/#/c/9153/5/testdata/workloads/functional-planner/queries/PlannerTest/with-clause.test@550 PS5, Line 550: # sure that noclustered hint prevents addition of a sort not before writing to HDFS. of a sort node -- To view, visit http://gerrit.cloudera.org:8080/9153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbf2368cf4415e6ecfa65058daf6ff87ef62f9d9 Gerrit-Change-Number: 9153 Gerrit-PatchSet: 5 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2018 23:04:48 +0000 Gerrit-HasComments: Yes
