Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 )
Change subject: IMPALA-6193: Track memory of incoming data streams ...................................................................... Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/8914/18/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/8914/18/be/src/rpc/impala-service-pool.cc@197 PS18, Line 197: nit: indent 4 http://gerrit.cloudera.org:8080/#/c/8914/18/be/src/runtime/krpc-data-stream-mgr.h File be/src/runtime/krpc-data-stream-mgr.h: http://gerrit.cloudera.org:8080/#/c/8914/18/be/src/runtime/krpc-data-stream-mgr.h@478 PS18, Line 478: // nit: /// http://gerrit.cloudera.org:8080/#/c/8914/17/be/src/runtime/krpc-data-stream-mgr.cc File be/src/runtime/krpc-data-stream-mgr.cc: http://gerrit.cloudera.org:8080/#/c/8914/17/be/src/runtime/krpc-data-stream-mgr.cc@398 PS17, Line 398: int64_t transfer_size = ctx->rpc_context->GetTransferSize(); : RespondToTimedOutSender<TransmitDataCtx, TransmitDataRequestPB>(ctx); : mem_tracker_->Release(transfer_size); nit: this can be moved into RespondToTimedOutSender() so you can use RespondAndReleaseRpc(). Please feel free to defer or ignore it as it's not critical. -- To view, visit http://gerrit.cloudera.org:8080/8914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df1204d2483313a8a18e5e3be6cec9e402614c4 Gerrit-Change-Number: 8914 Gerrit-PatchSet: 18 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2018 22:32:04 +0000 Gerrit-HasComments: Yes
