Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 )
Change subject: IMPALA-6193: Track memory of incoming data streams ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/8914/17/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/8914/17/be/src/rpc/impala-service-pool.cc@200 PS17, Line 200: > Should this be FailAndReleaseRpc() now? Or should the .release() logic be m Moved the .release call into the call to FailAndRelease(). We need a plain pointer variant of FailAndRelease to be called from RejectTooBusy(), which gets called with a dereferenced boost:optional<IncomingCall*>. We could however use function overloading to provide FailAndRelease for plain pointers, std::unique_ptr and gscoped_ptr. Let me know if this was your intention. http://gerrit.cloudera.org:8080/#/c/8914/17/be/src/runtime/krpc-data-stream-mgr.h File be/src/runtime/krpc-data-stream-mgr.h: http://gerrit.cloudera.org:8080/#/c/8914/17/be/src/runtime/krpc-data-stream-mgr.h@479 PS17, Line 479: // memory from 'mem_tracker'. Takes ownership of 'ctx'. > Document that this function takes over ownership of 'ctx' - at least I thin Done -- To view, visit http://gerrit.cloudera.org:8080/8914 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2df1204d2483313a8a18e5e3be6cec9e402614c4 Gerrit-Change-Number: 8914 Gerrit-PatchSet: 18 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 31 Jan 2018 18:11:39 +0000 Gerrit-HasComments: Yes
