Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 )
Change subject: IMPALA-3916: Reserve SQL:2016 reserved words ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9096/7/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/9096/7/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@88 PS7, Line 88: SqlScanner.init(TReservedWordsVersion.IMPALA_3_0); > - Adding a default value won't help because init() does more than reading t Be a bit wary of inheritance in tests. I find it often slows things down as people put more and more initialization in the base class that isn't necessary for everything. -- To view, visit http://gerrit.cloudera.org:8080/9096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b295e6a77e840cf1b794c2eb73e1b9d2b8ddd6 Gerrit-Change-Number: 9096 Gerrit-PatchSet: 7 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 00:16:04 +0000 Gerrit-HasComments: Yes
