Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 )
Change subject: IMPALA-3916: Reserve SQL:2016 reserved words ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/9096/9/fe/src/main/jflex/sql-scanner.flex File fe/src/main/jflex/sql-scanner.flex: http://gerrit.cloudera.org:8080/#/c/9096/9/fe/src/main/jflex/sql-scanner.flex@366 PS9, Line 366: // called again in the constructor of JniFrontend/JniCatalog, overwriting this called again in BackendConfig.create() right? http://gerrit.cloudera.org:8080/#/c/9096/9/fe/src/main/jflex/sql-scanner.flex@367 PS9, Line 367: // initilization. this initialization once the backend configuration is passed to the FE. http://gerrit.cloudera.org:8080/#/c/9096/7/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/9096/7/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@88 PS7, Line 88: > - Did the initilization as Alex suggested. You are right, custom cluster test seems sufficient http://gerrit.cloudera.org:8080/#/c/9096/9/tests/custom_cluster/test_reserved_words_version.py File tests/custom_cluster/test_reserved_words_version.py: http://gerrit.cloudera.org:8080/#/c/9096/9/tests/custom_cluster/test_reserved_words_version.py@18 PS9, Line 18: # Tests for query expiration. remove http://gerrit.cloudera.org:8080/#/c/9096/9/tests/custom_cluster/test_reserved_words_version.py@29 PS9, Line 29: impalad = self.cluster.get_any_impalad() Can't you use self.client? http://gerrit.cloudera.org:8080/#/c/9096/9/tests/custom_cluster/test_reserved_words_version.py@33 PS9, Line 33: self.execute_query_expect_success(client, "select 1 as `at`") Add an example with a SQL16 reserved word that we do not reserve because we have a builtin function with that name. For example you can use "avg" -- To view, visit http://gerrit.cloudera.org:8080/9096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b295e6a77e840cf1b794c2eb73e1b9d2b8ddd6 Gerrit-Change-Number: 9096 Gerrit-PatchSet: 9 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 02:25:45 +0000 Gerrit-HasComments: Yes
