Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 )
Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption ...................................................................... Patch Set 12: Code-Review-2 Looks like there was a clang-tidy failure. Could you have a look at that Xianda? https://jenkins.impala.io/job/clang-tidy-ub1604/630/artifact/tidylog.txt It looks like a simple fix. Just grep for "warning:" /home/ubuntu/Impala/be/src/util/openssl-util.h:135:58: warning: extra ';' after member function definition [clang-diagnostic-extra-semi] bool IsGcmMode() const { return mode_ == AES_256_GCM; }; -- To view, visit http://gerrit.cloudera.org:8080/9032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ea87b82a8897ee8bfa187715ac1c52883790d24 Gerrit-Change-Number: 9032 Gerrit-PatchSet: 12 Gerrit-Owner: Xianda Ke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Xianda Ke <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 18:50:35 +0000 Gerrit-HasComments: No
