Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 )
Change subject: IMPALA-3916: Reserve SQL:2016 reserved words ...................................................................... Patch Set 10: > Patch Set 10: > > > Patch Set 10: > > > > > Patch Set 10: Code-Review+2 > > > > Phil, in my understanding I should merge this, don't do anything to 2.x and > > wait for an update of > > https://jenkins.impala.io/job/cherrypick-2.x-and-test/. Is this correct? > > I think we don't want this in 2.x, right? If so, you should add > "Cherry-picks: not for 2.x." to the commit message. > > If we do want it in 2.x, you just wait for cherrypick-2.x-and-test. (To be > honest, I'm still working on that job, so depending on whether it's working, > it might be "just wait for Phil") Thanks! I think we want this for 2.x and it was the motivation for the command line flag. -- To view, visit http://gerrit.cloudera.org:8080/9096 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b295e6a77e840cf1b794c2eb73e1b9d2b8ddd6 Gerrit-Change-Number: 9096 Gerrit-PatchSet: 10 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Thu, 01 Feb 2018 21:29:53 +0000 Gerrit-HasComments: No
