Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#2). Change subject: IMPALA-6204: Remove external DataSource ...................................................................... IMPALA-6204: Remove external DataSource Removes DataSourceScanNode, external data sources, and all affiliated code, tests, and documentation. When a data source table is encountered, we now throw an exception. To the user, this looks like: [pannier.ca.cloudera.com:21000] > create table t (x int) stored as textfile tblproperties('__IMPALA_DATA_SOURCE_NAME'='V1'); Query: create table t (x int) stored as textfile tblproperties('__IMPALA_DATA_SOURCE_NAME'='V1') Fetched 0 row(s) in 0.11s [pannier.ca.cloudera.com:21000] > select * from t; Query: select * from t Query submitted at: 2018-02-01 17:16:26 (Coordinator: http://pannier.ca.cloudera.com:25000) ERROR: AnalysisException: Failed to load metadata for table: 't' CAUSED BY: TableLoadingException: Failed to load metadata for table: default.t. Running 'invalidate metadata default.t' may resolve this problem. CAUSED BY: UnsupportedOperationException: Eternal Data source table not supported. A test has been added to capture this behavior. For the most part, I deleted the unused code. In a few places, a renamed the Thrift enums and threw errors if they're encountered. For Thrift structs, I left a comment about the now-skipped id that used to represent a data-source related entry. Cherry-picks: not for 2.x Change-Id: I02a3a6740466ed7372b71d948c705b30886dcfb6 --- M CMakeLists.txt M be/generated-sources/gen-cpp/CMakeLists.txt M be/src/catalog/catalog-util.cc M be/src/exec/CMakeLists.txt M be/src/exec/catalog-op-executor.cc M be/src/exec/catalog-op-executor.h D be/src/exec/data-source-scan-node.cc D be/src/exec/data-source-scan-node.h M be/src/exec/exec-node.cc D be/src/exec/external-data-source-executor.cc D be/src/exec/external-data-source-executor.h M be/src/runtime/descriptors.cc M be/src/scheduling/scheduler.cc M be/src/service/client-request-state.cc M be/src/service/frontend.cc M be/src/service/frontend.h M be/src/service/impala-server.cc M bin/clean-cmake.sh M bin/clean.sh M buildall.sh M common/thrift/CMakeLists.txt M common/thrift/CatalogObjects.thrift M common/thrift/CatalogService.thrift M common/thrift/Data.thrift M common/thrift/Descriptors.thrift D common/thrift/ExternalDataSource.thrift M common/thrift/Frontend.thrift M common/thrift/JniCatalog.thrift M common/thrift/PlanNodes.thrift M docs/impala.ditamap D docs/topics/impala_create_data_source.xml D docs/topics/impala_data_sources.xml D docs/topics/impala_drop_data_source.xml D ext-data-source/.gitignore D ext-data-source/CMakeLists.txt D ext-data-source/api/pom.xml D ext-data-source/api/src/main/java/org/apache/impala/extdatasource/util/SerializationUtils.java D ext-data-source/api/src/main/java/org/apache/impala/extdatasource/v1/ExternalDataSource.java D ext-data-source/pom.xml D ext-data-source/sample/pom.xml D ext-data-source/sample/src/main/java/org/apache/impala/extdatasource/sample/EchoDataSource.java D ext-data-source/test/pom.xml D ext-data-source/test/src/main/java/org/apache/impala/extdatasource/AllTypesDataSource.java M fe/CMakeLists.txt M fe/pom.xml M fe/src/main/cup/sql-parser.cup M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java D fe/src/main/java/org/apache/impala/analysis/CreateDataSrcStmt.java D fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java D fe/src/main/java/org/apache/impala/analysis/DropDataSrcStmt.java M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java D fe/src/main/java/org/apache/impala/analysis/ShowDataSrcsStmt.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java D fe/src/main/java/org/apache/impala/catalog/DataSource.java D fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/catalog/Table.java D fe/src/main/java/org/apache/impala/extdatasource/ApiVersion.java D fe/src/main/java/org/apache/impala/extdatasource/ExternalDataSourceExecutor.java D fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M fe/src/test/java/org/apache/impala/analysis/ParserTest.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java M fe/src/test/java/org/apache/impala/planner/S3PlannerTest.java M fe/src/test/java/org/apache/impala/service/FrontendTest.java M impala-parent/pom.xml D testdata/bin/create-data-source-table.sql M testdata/bin/create-load-data.sh M testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test D testdata/workloads/functional-planner/queries/PlannerTest/data-source-tables.test M testdata/workloads/functional-planner/queries/PlannerTest/empty.test M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test A testdata/workloads/functional-query/queries/QueryTest/data-source-removed.test D testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test D testdata/workloads/functional-query/queries/QueryTest/show-data-sources.test M tests/metadata/test_ddl.py M tests/metadata/test_metadata_query_statements.py M tests/query_test/test_queries.py 88 files changed, 97 insertions(+), 4,621 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/9192/2 -- To view, visit http://gerrit.cloudera.org:8080/9192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I02a3a6740466ed7372b71d948c705b30886dcfb6 Gerrit-Change-Number: 9192 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>