Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 )
Change subject: IMPALA-3193: Show table's comment on show tables ...................................................................... Patch Set 13: (1 comment) The timed out issue at Jenkins should be resolved on this patch set. http://gerrit.cloudera.org:8080/#/c/8851/13/fe/src/main/java/org/apache/impala/service/MetadataOp.java File fe/src/main/java/org/apache/impala/service/MetadataOp.java: http://gerrit.cloudera.org:8080/#/c/8851/13/fe/src/main/java/org/apache/impala/service/MetadataOp.java@281 PS13, Line 281: try { : table = catalog.getTable(db.getName(), tabName); : } catch (TableLoadingException e) { : // Ignore exception (this table will be skipped). : } : if (table == null) continue; The removal of the code causes the timed out issue. The problem is infinite retries for not loaded table at Frontend.requestTblLoadAndWait. I thought the code should be duplicate. By the way, there are some conditions to check that a table is loaded, table type is come from IncompleteType and TableLoadingException happens. I prefer to revive the code instead of copy of essential code snippet due to avoidance of any side effect. Here is the relevant code for the condition: https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java#L250 -- To view, visit http://gerrit.cloudera.org:8080/8851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd Gerrit-Change-Number: 8851 Gerrit-PatchSet: 13 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Thu, 08 Feb 2018 13:53:45 +0000 Gerrit-HasComments: Yes
