Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8851 )

Change subject: IMPALA-3193: Show table's comment on show tables
......................................................................


Patch Set 13:

> I don't prefer to refactor the code to avoid the redundancy on this
 > change. I believe the last patch set is ready. Could you trigger
 > the dryrun again? Thanks.

I strongly recommend you reconsider this. Code clarity is very important. The 
current changes in MetadatOp.java introduce redundant operations that are not 
easy to explain.


--
To view, visit http://gerrit.cloudera.org:8080/8851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd
Gerrit-Change-Number: 8851
Gerrit-PatchSet: 13
Gerrit-Owner: Kim Jin Chul <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Kim Jin Chul <[email protected]>
Gerrit-Comment-Date: Fri, 09 Feb 2018 00:15:20 +0000
Gerrit-HasComments: No

Reply via email to