Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 )
Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9168/4/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/9168/4/be/src/common/init.cc@236 PS4, Line 236: // There is no way to pass MSG_NOSIGNAL into OpenSSL so the signal must be disabled. > Tell us more about this? Who sends SIGPIPE? I updated the comment. Without this the process crashes whenever an openssl socket closed on the other side is written. -- To view, visit http://gerrit.cloudera.org:8080/9168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c303997411237e988ef960157f781776f6fcb60 Gerrit-Change-Number: 9168 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:29:42 +0000 Gerrit-HasComments: Yes
